migrate Validator Domain Verifier to Redocly #2276
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No top level dependency changes detected. Learn more about Socket for GitHub ↗︎ |
mDuo13
force-pushed
the
redocly-migration
branch
from
9998c28 to
7f51ab4
Compare
ckniffen
force-pushed
the
migrate-validator-domain-verify
branch
from
df0f514 to
dc2105f
Compare
mDuo13
requested changes
Jan 9, 2024
There was a problem hiding this comment.
Tried a test merge based on the latest redocly-migration branch (running realm 0.71.1) and it largely works. I am seeing some errors in the browser console, though:
- If the pasted manifest isn't valid hex (i.e. trying with a base64 string returned by rippled's manifest method) it fails with a TypeError instead of gracefully.
Uncaught (in promise) TypeError: decodedManifest is undefined
parseAndVerifyManifest
...
- Each time you look up a manifest after the first, it throws a non-unique key error.
Warning: Encountered two children with the same key, `manifest-key`. Keys should be unique so that components maintain their identity across updates. Non-unique keys may cause children to be duplicated and/or omitted — the behavior is unsupported and could change in a future version.
Aside from that, this looks about ready to go.
# Conflicts: # package-lock.json # package.json
|
Merged as 49dc66f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
migrate https://xrpl.org/validator-domain-verifier.html to Redocly