Allow waiting for frames to complete rendering via GPU before sending to PipeWire consumers #1232
+37
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 8, 2025 18:14
…ndering via the GPU before being sent to PipeWire consumers, as well as updating functiion calls to dequeue_buffer_and_render to include new config argument for toggling wait functionality using wait_for_gpu_sync_in_screencasting debug field
coleleavitt
changed the title
YaLTeR
reviewed
Mar 9, 2025
| @@ -822,6 +823,7 @@ impl Cast { | |||
| elements: &[impl RenderElement<GlesRenderer>], | |||
| size: Size<i32, Physical>, | |||
| scale: Scale<f64>, | |||
| config: &Config | |||
There was a problem hiding this comment.
Instead of the full config, just pass a single bool wait_for_sync: bool
| ) { | ||
| warn!("error rendering to dmabuf: {err:?}"); | ||
| return false; | ||
| elements.iter().rev()) { |
There was a problem hiding this comment.
Don't forget to run cargo +nightly fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented
sync_point.wait()optional functionality if enabled in debug options viaconfig.kdlwithwait-for-gpu-sync-in-screencasting. Added a documentation entry in the Wiki under debug options (made it simplistic, to the point, following the other entries in the wiki so it isn't hard to understand)