Change double comparison to use epsilon instead of 0.0
#236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -503,7 +503,7 @@ void Ros_ActionServer_FJT_Goal_Complete(GOAL_END_TYPE goal_end_type) | |||
| diff = fabs(feedback_FollowJointTrajectory.feedback.desired.positions.data[axis] - feedback_FollowJointTrajectory.feedback.actual.positions.data[axis]); | |||
|
|
|||
| double posTolerance = g_actionServer_FJT_SendGoal_Request.goal.goal_tolerance.data[axis].position; //user-provided a goal_tolerance | |||
There was a problem hiding this comment.
should we not check whether g_actionServer_FJT_SendGoal_Request.goal.goal_tolerance.data is of the expected/required size? Otherwise we could be trying to read outside the array.
We might already be doing that before we get here, I haven't checked.
There was a problem hiding this comment.
We might already be doing that before we get here, I haven't checked
We're not.
You're correct in that this is another potential issue.
@yai-rosejo mentioned in passing that he's got a branch doing some more thorough checking. I'll let him comment on what he's done.
|
@ted-miller: I suggest we close this in favour of the more correct fix @yai-rosejo is preparing (#233 (comment)) |
|
agreed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding #233 (comment)
I don't know if this will have an impact on #233. But it does seem like a potential problem.