Skip to content
This repository was archived by the owner on Sep 7, 2023. It is now read-only.

fix(inline) proper local scoping for foreach and inlining code cleanup #640

Merged
merged 2 commits into from
Jul 26, 2019
Merged

fix(inline) proper local scoping for foreach and inlining code cleanup #640

merged 2 commits into from
Jul 26, 2019

Conversation

jeromesimeon
Copy link
Member

Issue #639

Properly handle scoping for foreach in inlining pass.

Changes

  • Clean up of inlining with clearer partial application
  • Call scoping function for foreach x in e in generic expression mapper
  • Chain scope properly through left-fold with context in foreach
  • Upgrade lodash dependencies

@jeromesimeon
chore(lodash) upgrade dependencies
6fdd021 
Signed-off-by: Jerome Simeon <jeromesimeon@me.com>
@jeromesimeon jeromesimeon force-pushed the js-fix-639-inlining branch from 169ed1d to c3449e6 Compare July 26, 2019 01:44
@jeromesimeon
fix(inline) proper local scoping for foreach and inlining code cleanup
40285ae 
Signed-off-by: Jerome Simeon <jeromesimeon@me.com>
@coveralls
Copy link

coveralls commented Jul 26, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 99.584% when pulling 40285ae on jeromesimeon:js-fix-639-inlining into 6e755cd on accordproject:master.

@jeromesimeon jeromesimeon force-pushed the js-fix-639-inlining branch from c3449e6 to 40285ae Compare July 26, 2019 01:49
@jeromesimeon jeromesimeon merged commit 4a8f9d4 into accordproject:master Jul 26, 2019
@jeromesimeon jeromesimeon mentioned this pull request Jul 26, 2019
Closed
@jeromesimeon jeromesimeon deleted the js-fix-639-inlining branch July 26, 2019 02:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeromesimeon @coveralls