Show recommended policy for new deployments #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyrahul
requested changes
Jan 12, 2023
- added deployment watcher to generate recommended policies when a new deployment is added Signed-off-by: Vishnu Soman <vishnu@accuknox.com>
nyrahul
approved these changes
Jan 18, 2023
seswarrajan
reviewed
Jan 18, 2023
| @@ -92,6 +92,7 @@ func (pc *PolicyStore) Publish(policy *types.PolicyYaml) { | |||
|
|
|||
| for consumer := range pc.Consumers { | |||
| if matchPolicyYaml(policy, consumer) { | |||
| log.Info().Msgf("Publishing policy %v", policy.Name) | |||
There was a problem hiding this comment.
Is this message necessary ?
The purpose of this message is for debug ?
| } | ||
| if !found { | ||
| log.Info().Msgf("Found Deployment %v in %v namespace", event.Object.(*v1.Deployment).Name, event.Object.(*v1.Deployment).Namespace) | ||
| generateHardenPolicy(event.Object.(*v1.Deployment).Name, event.Object.(*v1.Deployment).Namespace, event.Object.(*v1.Deployment).Spec.Template.Labels) |
There was a problem hiding this comment.
Are we extracting recommended policies based only on deployment name & labels
What if the same contains multiple containers ?? We are not getting recommended policies for containers ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vishnu Soman vishnu@accuknox.com