New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix _check_dns_entries for suggested apex domain substitutions for --domain-alias #6227

Closed

zeezooz wants to merge 1 commit into acmesh-official:dev from zeezooz:fix_check_dns_entries

zeezooz commented Feb 10, 2025

Current checks don't support @.domain.tld or .domain.tld, which are suggested to be used instead of the domain apex with --domain-alias at https://github.com/acmesh-official/acme.sh/wiki/DNS-alias-mode#7-challenge-alias-or-domain-alias
This fix removes "@." or "." at the beginning of the domain, so the correct domain will be checked.


          Fix _check_dns_entries for suggested apex domain substitutions for --…

5a4b6f3

…domain-alias

Current checks don't support @.domain.tld or .domain.tld, which are suggested to be used instead of the domain apex with --domain-alias at https://github.com/acmesh-official/acme.sh/wiki/DNS-alias-mode#7-challenge-alias-or-domain-alias
This fix removes "@." or "." at the beginning of the domain, so the correct domain will be checked.

Member

Neilpang commented Feb 19, 2025

docs updated, we should not support this kind of format.

Neilpang closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet