Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force node16 for js actions if FF is set #1686

Closed
wants to merge 9 commits into from
Closed

Force node16 for js actions if FF is set #1686

wants to merge 9 commits into from

Conversation

fhammerl
Copy link
Contributor

No description provided.

@fhammerl fhammerl marked this pull request as ready for review February 24, 2022 20:26
@fhammerl fhammerl requested a review from a team as a code owner February 24, 2022 20:26
@TingluoHuang
Copy link
Member

Can we split this PR into 2?
Looks like we are doing 2 different things in the PR.

  • some cleanup work with ForcedInternalNodeVersion
  • Adding new change to force all actions to use node16

@fhammerl
Copy link
Contributor Author

@TingluoHuang
Closing this in favour of
Internal Node 16: #1715
JS action Node 16: #1716

@fhammerl fhammerl closed this Feb 25, 2022
@fhammerl fhammerl mentioned this pull request Feb 25, 2022
Merged
@fhammerl fhammerl deleted the fhammerl/force-node16-gh-actions branch October 13, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TingluoHuang TingluoHuang TingluoHuang left review comments

@thboop thboop thboop left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fhammerl @TingluoHuang @thboop