Add fix for Windows caching of pip #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsafonkin
approved these changes
Feb 4, 2022
maxim-lobanov
approved these changes
Feb 4, 2022
MaksimZhukov
approved these changes
Feb 4, 2022
7 tasks
webknjaz
reviewed
Feb 16, 2025
| // Related issue: https://github.com/actions/setup-python/issues/328 | ||
| if (IS_WINDOWS) { | ||
| const execPromisify = utils.promisify(child_process.exec); | ||
| ({stdout: stdout, stderr: stderr} = await execPromisify('pip cache dir')); |
There was a problem hiding this comment.
When new pip versions get released, this call outputs the upgrade hint to stderr, which in turn gets misinterpreted as an error in the conditional below, causing this action to fail.
See #1034 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In scope of this pull request we add temporary fix for Windows caching.
Related issue: #328
Check list: