Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow for behavioral analysis of dependencies #1516

Closed
wants to merge 4 commits into from

Conversation

varunsh-coder
Copy link
Contributor

Pre-requisites


Please note that at this time we are only accepting new starter workflows for Code Scanning. Updates to existing starter workflows are fine.


Tasks

For all workflows, the workflow:

  • Should be contained in a .yml file with the language or platform as its filename, in lower, kebab-cased format (for example, docker-image.yml). Special characters should be removed or replaced with words as appropriate (for example, "dotnet" instead of ".NET").
  • Should use sentence case for the names of workflows and steps (for example, "Run tests").
  • Should be named only by the name of the language or platform (for example, "Go", not "Go CI" or "Go Build").
  • Should include comments in the workflow for any parts that are not obvious or could use clarification.
  • Should specify least priviledge permissions for GITHUB_TOKEN so that the workflow runs successfully.

For CI workflows, the workflow:

  • Should be preserved under the ci directory.
  • Should include a matching ci/properties/*.properties.json file (for example, ci/properties/docker-publish.properties.json).
  • Should run on push to branches: [ $default-branch ] and pull_request to branches: [ $default-branch ].
  • Packaging workflows should run on release with types: [ created ].
  • Publishing workflows should have a filename that is the name of the language or platform, in lower case, followed by "-publish" (for example, docker-publish.yml).

For Code Scanning workflows, the workflow:

  • Should be preserved under the code-scanning directory.
  • Should include a matching code-scanning/properties/*.properties.json file (for example, code-scanning/properties/codeql.properties.json), with properties set as follows:
    • name: Name of the Code Scanning integration.
    • organization: Name of the organization producing the Code Scanning integration.
    • description: Short description of the Code Scanning integration.
    • categories: Array of languages supported by the Code Scanning integration.
    • iconName: Name of the SVG logo representing the Code Scanning integration. This SVG logo must be present in the icons directory.
  • Should run on push to branches: [ $default-branch, $protected-branches ] and pull_request to branches: [ $default-branch ]. We also recommend a schedule trigger of cron: $cron-weekly (for example, codeql.yml).

Some general notes:

  • This workflow must only use actions that are produced by GitHub, in the actions organization, or
  • This workflow must only use actions that are produced by the language or ecosystem that the workflow supports. These actions must be published to the GitHub Marketplace. We require that these actions be referenced using the full 40 character hash of the action's commit instead of a tag. Additionally, workflows must include the following comment at the top of the workflow file:
    # This workflow uses actions that are not certified by GitHub.
    # They are provided by a third-party and are governed by
    # separate terms of service, privacy policy, and support
    # documentation.
    
  • Automation and CI workflows should not send data to any 3rd party service except for the purposes of installing dependencies.
  • Automation and CI workflows cannot be dependent on a paid service or product.

This workflow uses step-security/harden-runner GitHub Action to restrict outbound traffic to allowed endpoints. Observing network connectivity during the test stage of the CI pipeline can help detect potentially compromised upstream dependencies.

This workflow is specific to npm. I can create separate ones for other package managers and their respective registries. Please let me know.

@josepalafox

@varunsh-coder varunsh-coder requested a review from a team as a code owner April 7, 2022 17:21
@Phantsure
Copy link
Contributor

@varunsh-coder we are on a pause on accepting new starter-workflows for CI or automation. Code-scanning PRs are accepted. Refer: #631

@varunsh-coder
Copy link
Contributor Author

@varunsh-coder we are on a pause on accepting new starter-workflows for CI or automation. Code-scanning PRs are accepted. Refer: #631

Thanks @Phantsure. While this does not scan code, it does analyze dependencies and is related to security. From the developer’s perspective, does it make sense to add it to code scanning category?

If not, should I close the PR, or let it be open until the pause for accepting new starter-workflows is unpaused...

@Phantsure
Copy link
Contributor

@varunsh-coder It seems a better fit in code scanning. You can move to that. Thanks

Changed the category to dependency review to better align with what it does.
@varunsh-coder varunsh-coder requested a review from a team as a code owner April 24, 2022 14:13
@github-actions github-actions bot added the code-scanning Related to workflows that show on the Code Scanning setup page label Apr 24, 2022
@varunsh-coder
Copy link
Contributor Author

@varunsh-coder It seems a better fit in code scanning. You can move to that. Thanks

Thanks @Phantsure. I have moved it into code scanning. I saw there was new category called Dependency review which better aligns with this, so used that instead of Code Scanning.

Copy link
Contributor

@Phantsure Phantsure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@farahmandakbar farahmandakbar linked an issue May 4, 2022 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Aug 1, 2022

This pull request has become stale and will be closed automatically within a period of time. Sorry about that.

@github-actions
Copy link

github-actions bot commented Nov 7, 2022

This pull request has become stale and will be closed automatically within a period of time. Sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-scanning Related to workflows that show on the Code Scanning setup page no-pr-activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

14728a8ddfd0e03516920fdfd04c47bd49b1d66d
3 participants