-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create rushjs workflow #201
Conversation
Create a new starter workflow for rushjs
Add a comment about rushjs test command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ChocPanda and sorry for taking so long to getting around to reviewing this. I think there's a few improvements we can make to this and a question about the license for the logo.
@@ -0,0 +1,4 @@ | |||
<?xml version="1.0" encoding="UTF-8" standalone="no"?> | |||
<!-- Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT license. --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there anything else that states this license. I went to https://github.com/microsoft/rushstack and found no license file or anything stating we can redistribute this logo. I think we'll be ok, but I need to check.
|
||
echo 'Testing...' | ||
# This command does not ship with rushjs and would need to be implemented as a custom command https://rushjs.io/pages/configs/command_line_json/ | ||
node common/scripts/install-run-rush.js test --verbose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this won't run out of the box, a user would have to do something?
run: | | ||
set -e | ||
|
||
echo 'Installing...' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend removing these echo
and instead making steps for Install
, Test
and Build
. They will show up individually in the UI on GitHub.
Thanks @andymckay , I will address the comments later today and try to get confirmation on the logo license |
Co-authored-by: Andy McKay <andymckay@github.com>
Any luck with logo @ChocPanda |
This pull request has become stale and will be closed automatically within a period of time. Sorry about that. |
Create a new starter workflow for rushjs
Thank you for sending in this pull request. Please make sure you take a look at the contributing file. Here's a few things for you to consider in this pull request:
In the workflow and properties files:
ci/properties/*.properties.json
file.push
.release
withtypes: [created]
.Some general notes:
actions
organization.