-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBM OpenShift example Action #489
Conversation
Not sure why the CI error failed: https://github.com/actions/starter-workflows/pull/489/files#diff-4311fc13e12ea7f16e69350c90eb9ddd https://github.com/actions/starter-workflows/pull/489/checks?check_run_id=713891210#step:4:7 The file is there. |
@jjasghar 👋 |
- A basic example for IBM Cloud OpenShift Deployment - Installs the IBM Cloud CLI - Installs a version of OC to interface with OpenShift - Runs a create and deploy in OpenShift Signed-off-by: JJ Asghar <jjasghar@gmail.com> Signed-off-by: JJ Asghar <awesome@ibm.com>
@cschleiden do'h fixed. thanks :) |
per https://github.com/openshift/origin/releases/ this is the newest version Signed-off-by: JJ Asghar <jjasghar@gmail.com>
… into ibm_openshift
…into ibm_openshift
…into ibm_openshift
… into ibm_openshift
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I'm not sure about this one @jjasghar, I don't think it makes a great starter workflow. There's a large number of environment variables, several secrets and seems pretty complicated. I admit I don't know a lot about IBM OpenShift though.
Is there a way we can make this simpler? If it's an example, would a blog post or some other way of publishing it make sense?
This pull request has become stale and will be closed automatically within a period of time. Sorry about that. |
Noting that the open shift workflow has landed: https://github.com/github/c2c-actions/issues/2002 |
Signed-off-by: JJ Asghar jjasghar@gmail.com
Signed-off-by: JJ Asghar awesome@ibm.com
In the workflow and properties files:
The workflow filename of CI workflows should be the name of the language or platform, in lower case. Special characters should be removed or replaced with words as appropriate (for example, "dotnet" instead of ".NET").
The workflow filename of publishing workflows should be the name of the language or platform, in lower case, followed by "-publish".
Includes a matching
ci/properties/*.properties.json
file.Use sentence case for the names of workflows and steps, for example "Run tests".
The name of CI workflows should only be the name of the language or platform: for example "Go" (not "Go CI" or "Go Build")
Include comments in the workflow for any parts that are not obvious or could use clarification.
CI workflows should run on
push
tobranches: [ master ]
andpull_request
tobranches: [ master ]
.Packaging workflows should run on
release
withtypes: [ created ]
.Some general notes:
This workflow must only use actions that are produced by GitHub, in the
actions
organization, orThis workflow must only use actions that are produced by the language or ecosystem that the workflow supports. These actions must be published to the GitHub Marketplace. Workflows using these actions must reference the action using the full 40 character hash of the action's commit instead of a tag. Additionally, workflows must include the following comment at the top of the workflow file:
This workflow must not send data to any 3rd party service except for the purposes of installing dependencies.
This workflow must not use a paid service or product.