Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Symfony template #526

Closed
wants to merge 1 commit into from
Closed

Conversation

sci3ma
Copy link

@sci3ma sci3ma commented May 23, 2020

Template to setup minimal environment to run unit and functional tests in Symfony using PHPUnit (Symfony's PHPUnit Bridge)

Briefly the template does:

  • run a environment with ubuntu latest version
  • checkout your code in the environment
  • add directory permissions
  • create a empty sqlite database
  • execute the tests via phpunit injecting a couple of environment variables in order to use the sqlite database created

Copy link
Contributor

@andymckay andymckay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sci3ma I've put a suggestion and question in the review.

Comment on lines +5 to +7
branches: [ master ]
pull_request:
branches: [ master ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
branches: [ master ]
pull_request:
branches: [ master ]
branches: [ $default-branch ]
pull_request:
branches: [ $default-branch ]

- uses: actions/checkout@v2

- name: Install Dependencies
run: composer install -q --no-ansi --no-interaction --no-scripts --no-suggest --no-progress --prefer-dist
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I try this I get


Run composer install -q --no-ansi --no-interaction --no-scripts --no-suggest --no-progress --prefer-dist
  composer install -q --no-ansi --no-interaction --no-scripts --no-suggest --no-progress --prefer-dist
  shell: /bin/bash -e {0}
##[error]Process completed with exit code 1.

Suggesting that composer isn't present, where would a user get composer from?

@sci3ma
Copy link
Author

sci3ma commented Sep 7, 2020

@andymckay Sorry for late response, I'm sooo busy :( I assumed that if anyone uses Symfony Framework then has to have composer installed. Feel free to improve this PR with your chances as I don't know when I'll find some free time.

@andymckay
Copy link
Contributor

@andymckay Sorry for late response, I'm sooo busy :( I assumed that if anyone uses Symfony Framework then has to have composer installed. Feel free to improve this PR with your chances as I don't know when I'll find some free time.

Thanks for the reply @sci3ma and sorry for the slow reply on my side in the first place. At this point, we expect a starter workflow to work as well as possible out of the box and I imagine users would like help installing Symfony in their VM. If anyone else is willing to contribute to this PR, then we can move it forwards, otherwise I recommend we close it. We can always re-open it later if you get some time and want to work on it.

@andymckay andymckay closed this Sep 28, 2020
@TheGarious
Copy link
Contributor

Hello,

I can retake this PR.

Maybe recreate a new pr ?

@sci3ma
Copy link
Author

sci3ma commented Sep 3, 2021

Hello,

I can retake this PR.

Maybe recreate a new pr ?

Sure :) go ahead.

@TheGarious
Copy link
Contributor

TheGarious commented Sep 3, 2021

Good !

I create a pr a few days ago with this point.

#1069

Needed reviewal!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants