Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Phoenix starter workflow #591

Closed
wants to merge 4 commits into from
Closed

Add Phoenix starter workflow #591

wants to merge 4 commits into from

Conversation

jclem
Copy link
Contributor

@jclem jclem commented Jul 14, 2020

Add a Phoenix starter workflow

Phoenix is a popular web application framework for the Elixir programming language (for which we have a starter workflow). This pull request adds a workflow similar to the Elixir workflow—the main difference is that I've added a Postgres service (Postgres is the default database for new Phoenix projects).

Links

To Do

  • Get SVG and understand usage rights of Phoenix logo.

In the workflow and properties files:

  • The workflow filename of CI workflows should be the name of the language or platform, in lower case. Special characters should be removed or replaced with words as appropriate (for example, "dotnet" instead of ".NET").
  • The workflow filename of publishing workflows should be the name of the language or platform, in lower case, followed by "-publish".
  • Includes a matching ci/properties/*.properties.json file.
  • Use sentence case for the names of workflows and steps, for example "Run tests".
  • The name of CI workflows should only be the name of the language or platform: for example "Go" (not "Go CI" or "Go Build")
  • Include comments in the workflow for any parts that are not obvious or could use clarification.
  • CI workflows should run on push to branches: [ master ] and pull_request to branches: [ master ].
  • Packaging workflows should run on release with types: [ created ].

Some general notes:

  • This workflow must only use actions that are produced by GitHub, in the actions organization, or
  • This workflow must only use actions that are produced by the language or ecosystem that the workflow supports. These actions must be published to the GitHub Marketplace. Workflows using these actions must reference the action using the full 40 character hash of the action's commit instead of a tag. Additionally, workflows must include the following comment at the top of the workflow file:
    # This workflow uses actions that are not certified by GitHub.
    # They are provided by a third-party and are governed by
    # separate terms of service, privacy policy, and support
    # documentation.
    
  • This workflow must not send data to any 3rd party service except for the purposes of installing dependencies.
  • This workflow must not use a paid service or product.

@andymckay andymckay changed the base branch from master to main August 21, 2020 19:22
Copy link
Contributor

@andymckay andymckay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @jclem, we'll just need to get that logo 👍🏾

@bruce
Copy link

bruce commented Aug 21, 2020

Looks good @jclem, we'll just need to get that logo 👍🏾

I reached out to @chrismccord to see if there's a process we need to follow.

@chrismccord
Copy link

This is great! GitHub has my permission to use the Phoenix logo for the starter workflows. I generally avoid making SVG publicly available as it becomes difficult to enforce usage with infinitely high res versions out there, so let me know if the following png is sufficient. Thanks!
phx-logo

@jclem
Copy link
Contributor Author

jclem commented Aug 22, 2020

Thank you @chrismccord and @bruce! I think the png is sufficient—I'll take a look Monday to double check.

@jclem
Copy link
Contributor Author

jclem commented Sep 1, 2020

@andymckay Do you know if a PNG will work for this? I noticed that iconName is just a string, so I'm curious if the rendering assumes that it will be an SVG.

Copy link

@tonirmv tonirmv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
Copy link

This pull request has become stale and will be closed automatically within a period of time. Sorry about that.

@Monssif1
Copy link

مرحبا

@Monssif1
Copy link

انا جديد في هد الميدان

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants