Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create alibabacloud.yml #742

Merged
merged 10 commits into from
Jan 12, 2021
Merged

Create alibabacloud.yml #742

merged 10 commits into from
Jan 12, 2021

Conversation

ljinging
Copy link
Contributor

This workflow will build and push a new container image to Alibaba Cloud Container Registry (ACR),
and then will deploy it to Alibaba Cloud Container Service for Kubernetes (ACK), when a release is created.

This workflow will build and push a new container image to Alibaba Cloud Container Reigstry (ACR),
and then will deploy it to Alibaba Cloud Container Service for Kubernetes (ACK), when a release is created.
@ljinging ljinging requested a review from a team December 11, 2020 15:05
@andymckay
Copy link
Contributor

Thanks @ljinging but I think this is covered by #631 unless you can find an exception for that.

@@ -0,0 +1 @@
<svg id="图层_1" data-name="图层 1" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 113.39 113.39"><defs><style>.cls-1{fill:#fff;}.cls-2{fill:#ff6a00;}</style></defs><title>AlibabacloudLogoGithub</title><circle class="cls-1" cx="56.69" cy="56.69" r="56.69"/><rect class="cls-2" x="45.85" y="54.14" width="21.69" height="4.89"/><path class="cls-2" d="M78.4,36.4H64.05l3.47,4.9L78,44.5a4.54,4.54,0,0,1,3.16,4.35h0V64.53h0A4.52,4.52,0,0,1,78,68.88L67.52,72.09,64.05,77H78.4A10.84,10.84,0,0,0,89.24,66.15V47.24A10.84,10.84,0,0,0,78.4,36.4Z"/><path class="cls-2" d="M35,36.4H49.33l-3.46,4.9L35.41,44.5a4.52,4.52,0,0,0-3.16,4.35h0V64.53h0a4.51,4.51,0,0,0,3.16,4.34l10.46,3.21L49.33,77H35A10.84,10.84,0,0,1,24.14,66.15V47.24A10.84,10.84,0,0,1,35,36.4Z"/></svg>
Copy link
Contributor

@chenrui333 chenrui333 Jan 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to have id and data-name

Suggested change
<svg id="图层_1" data-name="图层 1" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 113.39 113.39"><defs><style>.cls-1{fill:#fff;}.cls-2{fill:#ff6a00;}</style></defs><title>AlibabacloudLogoGithub</title><circle class="cls-1" cx="56.69" cy="56.69" r="56.69"/><rect class="cls-2" x="45.85" y="54.14" width="21.69" height="4.89"/><path class="cls-2" d="M78.4,36.4H64.05l3.47,4.9L78,44.5a4.54,4.54,0,0,1,3.16,4.35h0V64.53h0A4.52,4.52,0,0,1,78,68.88L67.52,72.09,64.05,77H78.4A10.84,10.84,0,0,0,89.24,66.15V47.24A10.84,10.84,0,0,0,78.4,36.4Z"/><path class="cls-2" d="M35,36.4H49.33l-3.46,4.9L35.41,44.5a4.52,4.52,0,0,0-3.16,4.35h0V64.53h0a4.51,4.51,0,0,0,3.16,4.34l10.46,3.21L49.33,77H35A10.84,10.84,0,0,1,24.14,66.15V47.24A10.84,10.84,0,0,1,35,36.4Z"/></svg>
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 113.39 113.39"><defs><style>.cls-1{fill:#fff;}.cls-2{fill:#ff6a00;}</style></defs><title>AlibabacloudLogoGithub</title><circle class="cls-1" cx="56.69" cy="56.69" r="56.69"/><rect class="cls-2" x="45.85" y="54.14" width="21.69" height="4.89"/><path class="cls-2" d="M78.4,36.4H64.05l3.47,4.9L78,44.5a4.54,4.54,0,0,1,3.16,4.35h0V64.53h0A4.52,4.52,0,0,1,78,68.88L67.52,72.09,64.05,77H78.4A10.84,10.84,0,0,0,89.24,66.15V47.24A10.84,10.84,0,0,0,78.4,36.4Z"/><path class="cls-2" d="M35,36.4H49.33l-3.46,4.9L35.41,44.5a4.52,4.52,0,0,0-3.16,4.35h0V64.53h0a4.51,4.51,0,0,0,3.16,4.34l10.46,3.21L49.33,77H35A10.84,10.84,0,0,1,24.14,66.15V47.24A10.84,10.84,0,0,1,35,36.4Z"/></svg>

Copy link
Contributor

@imjohnbo imjohnbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request. Approved.

@imjohnbo imjohnbo merged commit 97cad8d into actions:main Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants