Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@actions/attest: Support multi-subject attestations #1865

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

bdehamer
Copy link
Contributor

Updates the attest and attestProvenance functions to accept an array of subjects which can be added to a single attestation.

Previously, these functions accepted a single subject name and digest -- allowing the consumer to create an attested intoto statement for just a single subject. This change deprecates the subjectName/subjectDigest params in favor of a new subjects option which accepts an array of subjects.

@bdehamer bdehamer requested a review from a team as a code owner October 30, 2024 21:16
@bdehamer bdehamer force-pushed the bdehamer/multi-subject branch from b80955f to 867dac2 Compare October 30, 2024 23:03
Copy link
Contributor

@kommendorkapten kommendorkapten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Failing test on macOS seems unrelated:

Summary of all failing tests
FAIL packages/exec/__tests__/exec.test.ts (6.996 s)
  ● @actions/exec › Handles child process holding streams open

Is this an intermittent failure or does it fail on main too?

Liabaemt

This comment was marked as spam.

@actions actions deleted a comment from Liabaemt Oct 31, 2024
Signed-off-by: Brian DeHamer <bdehamer@github.com>
@bdehamer bdehamer force-pushed the bdehamer/multi-subject branch from 867dac2 to 265a5be Compare November 1, 2024 16:08
@bdehamer bdehamer merged commit 43ce96d into main Nov 1, 2024
14 checks passed
@bdehamer bdehamer deleted the bdehamer/multi-subject branch November 1, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants