Fix violation code conflicts with flake8-import-order
#108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds 50 to the violation codes: | OLD CODE | NEW CODE | VIOLATION | | ------------ | ------------- | ------------ | | I200 | I250 | Unnecessary import alias | I200 | I251 | Banned import
|
Closes #106 |
|
I'll have to look at why the tests are failing later |
|
Hi, Sorry I didn't reply before. Would you have time to rebase this on top of changes since, and ensure the tests pass? Thanks, Adam |
|
Superceded by #176. |
|
#176 was merged and this has been released in version 4.0.0: https://pypi.org/project/flake8-tidy-imports/4.0.0/ 🎺 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds 50 to the violation codes: