-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for GNGNS Strings #42
Conversation
Allowed Floats for GPGSV and GLGSV
Tighter EnumChars loop
Considering that the mode values are contextual, I don't see the use-case for the |
@bmurray I'm ready to merge it if you revert back to the original PR (and the tests are passing). |
@adrianmo the change to a |
Reverted float to int for GSV SNR values
Thinking more about it, the *GSV values should be Int64, as that's what's in the spec. The library shouldn't compromise for broken chips. I've also removed the IsMode from the GNGNS string. Test's are all passing on my end. |
@bmurray the CI is failing because everything exported needs to be commented. I'm not the owner, so I can't merge until it's passing. |
Hm, they're commented now, and it runs against current Go. I don't know what those other errors are related to; it seems like Travis-CI is having issues pulling golint ? |
Test against Go 1.11.x
Looks like 1.11, and 1.10 are the only ones officially supported for lint. Should just drop testing against 1.7 and 1.8; 1.9 still works for now, so that's a bit of a tossup. |
Thanks for the contribution! |
I also rolled in a change to allow SNR values to be Floats. I have a receiver that always reports SNR with a float value.