-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - Adding mention user support in issue comments #360
base: master
Are you sure you want to change the base?
Conversation
This is feature complete in my books, but I'll be testing it for a week or more before PRing.
Nice! Maybe some people could try this out pre-merge and give a thumbs up if it seems non-impactful to their existing workflows / new features seem to operate without any hiccups. |
I tried to get it working but I it didn't work for me. The function |
This would be really nice to have |
Would you be able to share the whole error? I have been meaning to comeback to finishing this PR. The interface should not change much, but I am re-working it and adding as much testing as I can before PRing it. |
@djgoku I get this error when invoking org-jira-mention-user |
@djgoku any update on this ? Are you planning on working on this ? |
Yes! I should have sometime this weekend to work on this. @dhruvasagar Thanks for the nudge. |
Would love this! |
This is feature complete, but I want to do more testing. I'll also break up the commits once it is closer to merging.
Also there was a type bug (should be boolean and not a string) in the
org-jira-update-issues-details-include-reporter
variable I added.@ahungry While testing this (new Jira Cloud account) I had to conditionally disable updating issue details for
components
andpriority
. I can't say I like this, but haven't really thought of a better way to implement this.Features:
M-x org-jira-mention-user
(not sure if there is more we can do here).PROJECT.org
where allPROJECT
issues are saved. Issue comments now show display name over[~accountid:8675309]
.Implements #254 #221