[3.11] Make creating RequestInfo backwards compatible with 3.10
#9872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was unexpected that this object was being created directly outside of aiohttp internals. While it looks like its only used for mocking downstream, we can accomodate that by subclassing the NamedTuple and providing a `__new__` while keeping the faster `tuple.__new__` internally. fixes #9866
bdraco
changed the title
RequestInfo backwards compatible with 3.10
bdraco
changed the title
RequestInfo backwards compatible with 3.10RequestInfo backwards compatible with 3.10
|
Really not harm in doing this on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was unexpected that this object was being created directly
outside of aiohttp internals. While it looks like its only
used for mocking downstream, we can accomodate that by subclassing
the NamedTuple and providing a
__new__while keeping the fastertuple.__new__internally.fixes #9866