Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #9873/c9698c8e backport][3.12] Make creating RequestInfo backwards compatible with 3.10 #9886

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Nov 14, 2024

This is a backport of PR #9873 as merged into master (c9698c8).

It was unexpected that this object was being created directly outside of aiohttp internals. While it looks like its only used for mocking internal state downstream, we can accommodate that by subclassing the NamedTuple and providing a __new__ while keeping the faster tuple.__new__ internally.

We might remove the back-compat later in 4.x development cycle, however since its currently being used downstream to mock internals and there isn't a better prescribed way to do that, leave it for now.

fixes #9866

Copy link

codspeed-hq bot commented Nov 14, 2024

CodSpeed Performance Report

Merging #9886 will not alter performance

Comparing patchback/backports/3.12/c9698c8ecadc344a55e8b05d5c43391e39443ad9/pr-9873 (262a3d5) with master (a118114)

Summary

✅ 24 untouched benchmarks

@bdraco bdraco merged commit 32c896d into 3.12 Nov 14, 2024
33 of 34 checks passed
@bdraco bdraco deleted the patchback/backports/3.12/c9698c8ecadc344a55e8b05d5c43391e39443ad9/pr-9873 branch November 14, 2024 21:12
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (3.12@b580b86). Learn more about missing BASE report.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.12    #9886   +/-   ##
=======================================
  Coverage        ?   97.99%           
=======================================
  Files           ?      119           
  Lines           ?    36397           
  Branches        ?     4363           
=======================================
  Hits            ?    35668           
  Misses          ?      545           
  Partials        ?      184           
Flag Coverage Δ
CI-GHA 97.88% <100.00%> (?)
OS-Linux 97.58% <100.00%> (?)
OS-Windows 94.44% <100.00%> (?)
OS-macOS 96.69% <100.00%> (?)
Py-3.10.11 96.54% <100.00%> (?)
Py-3.10.15 97.09% <100.00%> (?)
Py-3.11.10 97.16% <100.00%> (?)
Py-3.11.9 96.61% <100.00%> (?)
Py-3.12.7 97.65% <100.00%> (?)
Py-3.13.0 97.65% <100.00%> (?)
Py-3.9.13 96.47% <100.00%> (?)
Py-3.9.20 97.05% <100.00%> (?)
Py-pypy7.3.16 96.60% <100.00%> (?)
VM-macos 96.69% <100.00%> (?)
VM-ubuntu 97.58% <100.00%> (?)
VM-windows 94.44% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant