Support engine events and detect config watcher failed #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akrambek
previously approved these changes
Jun 27, 2024
vordimous
suggested changes
Jun 27, 2024
...gine/src/main/java/io/aklivity/zilla/runtime/engine/internal/event/EngineEventFormatter.java
Outdated
Show resolved
Hide resolved
vordimous
previously approved these changes
Jun 27, 2024
vordimous
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creates a new
eventsfile for events at engine scope, in addition to per-core engine workers. Updates event reader to include these events as well so they are all picked up automatically by telemetry exporters.Detect when
FileSystem.newWatchService()fails, and record engine event, then still continue startup with observedzilla.yamlconfiguration.Fixes #1081