Verify public-private tls key pair #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfallows
requested changes
Jun 27, 2024
specs/binding-tls.spec/src/main/resources/META-INF/zilla/tls.idl
Outdated
Show resolved
Hide resolved
...ls/src/main/java/io/aklivity/zilla/runtime/binding/tls/internal/config/TlsBindingConfig.java
Outdated
Show resolved
Hide resolved
...ls/src/main/java/io/aklivity/zilla/runtime/binding/tls/internal/config/TlsBindingConfig.java
Show resolved
Hide resolved
...ls/src/main/java/io/aklivity/zilla/runtime/binding/tls/internal/config/TlsBindingConfig.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/aklivity/zilla/runtime/binding/tls/internal/config/TlsKeyPairVerifier.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/aklivity/zilla/runtime/binding/tls/internal/config/TlsKeyPairVerifier.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/aklivity/zilla/runtime/binding/tls/internal/config/TlsKeyPairVerifier.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/aklivity/zilla/runtime/binding/tls/internal/config/TlsKeyPairVerifier.java
Outdated
Show resolved
Hide resolved
|
|
||
| public class TlsKeyPairVerifier | ||
| { | ||
| private static final String ALGORITHM = "SHA256withRSA"; |
There was a problem hiding this comment.
We discussed other key types like Elliptic Curve that would require a different algorithm, agree?
|
|
||
| public class TlsKeyPairVerifierTest | ||
| { | ||
| private static final String PRIVATE_KEY = """ |
There was a problem hiding this comment.
I think this is an RSA key. We'll need ECDSA too.
jfallows
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change verifies the public-private key pair obtained from vault. Logs an event if public-private key pair is invalid or missing.
Fixes #1073