Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use integer for challenge type #1252

Merged
merged 1 commit into from
Sep 18, 2024
Merged

fix: use integer for challenge type #1252

merged 1 commit into from
Sep 18, 2024

Conversation

vordimous
Copy link
Contributor

Description

updates the type for the challenge options on the jwt guard.

@vordimous vordimous requested a review from jfallows September 18, 2024 12:58
@vordimous vordimous mentioned this pull request Sep 18, 2024
Merged
@jfallows jfallows requested a review from ankitk-me September 18, 2024 16:23
ankitk-me
ankitk-me approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@ankitk-me ankitk-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfallows jfallows merged commit 25df275 into develop Sep 18, 2024
5 checks passed
@vordimous vordimous deleted the update-challenge-type branch November 5, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfallows jfallows jfallows approved these changes

@ankitk-me ankitk-me ankitk-me approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vordimous @jfallows @ankitk-me