Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support risingwave include keyword #1259

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Support risingwave include keyword #1259

merged 3 commits into from
Sep 20, 2024

Conversation

akrambek
Copy link
Contributor

No description provided.

jfallows
jfallows reviewed Sep 20, 2024
View reviewed changes
Copy link
Contributor

@jfallows jfallows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest renaming to remove .headers from scenario name, since from pgsql perspective these are not headers.

Also, do we need scenarios for create.table.with.primary.key.and.includes ?

@jfallows jfallows merged commit 537be06 into aklivity:develop Sep 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfallows jfallows jfallows approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akrambek @jfallows