Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create external function issue fix #1271

Merged
merged 1 commit into from
Sep 28, 2024
Merged

create external function issue fix #1271

merged 1 commit into from
Sep 28, 2024

Conversation

ankitk-me
Copy link
Contributor

No description provided.

jfallows
jfallows requested changes Sep 27, 2024
View reviewed changes
...aklivity/zilla/runtime/binding/risingwave/internal/statement/RisingwaveSqlCommandParser.java
"|\\b(CREATE FUNCTION)\\b.*?RETURNS TABLE.*?AS.*?;[\\x00\\n]*" +
"|\\b(CREATE FUNCTION)\\b.*?RETURNS .*?AS.*?;[\\x00\\n]*" +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to support both RETURNS and RETURNS TABLE.

@jfallows jfallows merged commit e847f01 into aklivity:develop Sep 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfallows jfallows jfallows approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ankitk-me @jfallows