pgsql ALTER TOPIC command to register new schema #1309
Conversation
| : ALTER opttable_alter_type (IF_P EXISTS)? relation_expr (alter_table_cmds | partition_cmd) | ||
| | ALTER opttable_alter_type ALL IN_P TABLESPACE name (OWNED BY role_list)? SET TABLESPACE name opt_nowait |
There was a problem hiding this comment.
Seems they are listing out the possibles explicitly, why not just put ALTER TABLE and ALTER TOPIC here too?
There was a problem hiding this comment.
I thought since they are logically exactly the same the use like alias
There was a problem hiding this comment.
Understood, prefer we list them out explicitly if that's okay with you.
| @@ -36,9 +36,9 @@ public SqlCreateStreamListener( | |||
| this.tokens = tokens; | |||
| } | |||
|
|
|||
| public StreamInfo streamInfo() | |||
| public Stream streamInfo() | |||
There was a problem hiding this comment.
If you want to have a suffix for these model class names, consider Model instead of Info.
Alternatively consider a prefix like PgsqlStream.
There was a problem hiding this comment.
I actually removed suffixes from all other places this got missed
| "${app}/alter.topic.unsupported.operation/client", | ||
| "${app}/alter.topic.unsupported.operation/server" | ||
| }) | ||
| public void shouldNotAlterTopicColumn() throws Exception |
There was a problem hiding this comment.
| public void shouldNotAlterTopicColumn() throws Exception | |
| public void shouldNotAlterTopicModifyColumn() throws Exception |
?
| "${app}/alter.topic.unsupported.operation/client", | ||
| "${app}/alter.topic.unsupported.operation/server" |
There was a problem hiding this comment.
| "${app}/alter.topic.unsupported.operation/client", | |
| "${app}/alter.topic.unsupported.operation/server" | |
| "${app}/alter.topic.modify.column.rejected/client", | |
| "${app}/alter.topic.modify.column.rejected/server" |
| throw new UnsupportedOperationException( | ||
| String.format("Unsupported alter operation: %s", alterExpr.operation())); |
There was a problem hiding this comment.
This is using exceptions for flow control, which we typically avoid because it is heavy.
| "${pgsql}/alter.topic.unsupported.operation/client" | ||
| }) | ||
| public void shouldNotAlterTopicColumn() throws Exception |
There was a problem hiding this comment.
| "${pgsql}/alter.topic.unsupported.operation/client" | |
| }) | |
| public void shouldNotAlterTopicColumn() throws Exception | |
| "${pgsql}/alter.topic.modify.column.rejected/client" | |
| }) | |
| public void shouldNotAlterTopicModifyColumn() throws Exception |
Fixes #1058