Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude package-info.class from delegate module to avoid empty packages #1343

Conversation

jfallows
Copy link
Contributor

@jfallows jfallows commented Dec 4, 2024

Description

jdeps generates a module-info.java that exports packages even if they have only package-info.class.
jlink complains that a package is empty, even if it includes package-info.class.

So, we need to exclude package-info.class from the delegate module to prevent jdeps from generating a module-info.java that is incompatible with jlink.

@jfallows jfallows enabled auto-merge (squash) December 4, 2024 00:47
@jfallows jfallows merged commit 5299243 into aklivity:develop Dec 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants