Client topic space #507
Merged
Client topic space #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfallows
requested changes
Oct 14, 2023
...in/java/io/aklivity/zilla/runtime/binding/kafka/internal/stream/KafkaCacheClientFactory.java
Show resolved
Hide resolved
...scripts/io/aklivity/zilla/specs/binding/mqtt/kafka/config/proxy.when.client.topic.space.yaml
Outdated
Show resolved
Hide resolved
...scripts/io/aklivity/zilla/specs/binding/mqtt/kafka/config/proxy.when.client.topic.space.yaml
Show resolved
Hide resolved
...cripts/io/aklivity/zilla/specs/binding/mqtt/kafka/config/proxy.when.topic.with.messages.yaml
Outdated
Show resolved
Hide resolved
.../main/scripts/io/aklivity/zilla/specs/binding/mqtt/kafka/schema/mqtt.kafka.schema.patch.json
Show resolved
Hide resolved
| .header("zilla:filter", "clients") | ||
| .header("zilla:filter", "client-2") | ||
| .header("zilla:filter", "sensors") | ||
| .header("zilla:filter", "one") |
There was a problem hiding this comment.
Is this missing a leading .header("zilla:filter", "") to represent the empty segment before the leading / in the mqtt topic name?
Perhaps it would be more readable to include the leading / for each segment in the zilla:filter header value, then omit the leading / when not present at the start of the mqtt topic name to differentiate instead of needing a leading empty "" header value? That would be a backwards incompatible change, but if we want to do it we should do it sooner than later. Let's discuss.
.../aklivity/zilla/specs/binding/mqtt/kafka/streams/kafka/publish.client.topic.space/client.rpt
Outdated
Show resolved
Hide resolved
bmaidics
force-pushed
the
topic_space_clientid
branch
from
2de0c8a to
dc63f5c
Compare
jfallows
requested changes
Oct 27, 2023
.../io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/config/MqttKafkaConditionMatcher.java
Outdated
Show resolved
Hide resolved
.../java/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/config/MqttKafkaRouteConfig.java
Outdated
Show resolved
Hide resolved
...ava/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/config/MqttKafkaBindingConfig.java
Outdated
Show resolved
Hide resolved
...ava/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/config/MqttKafkaBindingConfig.java
Outdated
Show resolved
Hide resolved
...ava/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/config/MqttKafkaBindingConfig.java
Show resolved
Hide resolved
.../io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaSubscribeFactory.java
Outdated
Show resolved
Hide resolved
.../io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaSubscribeFactory.java
Outdated
Show resolved
Hide resolved
.../io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaSubscribeFactory.java
Outdated
Show resolved
Hide resolved
.../io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaSubscribeFactory.java
Outdated
Show resolved
Hide resolved
.../io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaSubscribeFactory.java
Outdated
Show resolved
Hide resolved
bmaidics
force-pushed
the
topic_space_clientid
branch
from
c8d0607 to
784693f
Compare
bmaidics
force-pushed
the
topic_space_clientid
branch
from
784693f to
5a10e25
Compare
jfallows
requested changes
Oct 30, 2023
...ava/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/config/MqttKafkaBindingConfig.java
Outdated
Show resolved
Hide resolved
.../io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/config/MqttKafkaConditionMatcher.java
Outdated
Show resolved
Hide resolved
.../io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/config/MqttKafkaConditionMatcher.java
Outdated
Show resolved
Hide resolved
...va/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaPublishFactory.java
Outdated
Show resolved
Hide resolved
...va/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaPublishFactory.java
Outdated
Show resolved
Hide resolved
...java/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaProxyFactory.java
Outdated
Show resolved
Hide resolved
.../io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaSubscribeFactory.java
Outdated
Show resolved
Hide resolved
.../io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaSubscribeFactory.java
Outdated
Show resolved
Hide resolved
jfallows
requested changes
Oct 30, 2023
.../java/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/config/MqttKafkaRouteConfig.java
Outdated
Show resolved
Hide resolved
.../io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/config/MqttKafkaConditionMatcher.java
Outdated
Show resolved
Hide resolved
.../io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaSubscribeFactory.java
Outdated
Show resolved
Hide resolved
jfallows
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.