Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jumbograms and proxy extension parsing to dump command #635

Merged
merged 22 commits into from
Dec 14, 2023
Merged

Add jumbograms and proxy extension parsing to dump command #635

merged 22 commits into from
Dec 14, 2023

Conversation

attilakreiner
Copy link
Contributor

@attilakreiner attilakreiner commented Dec 12, 2023 •
edited
Loading

Description

This commit adds these features to the dump command:

  • support of IPv6 Jumbograms to accommodate large frames
  • adds the worker index and streams buffer offset
  • adds the ability to dissect proxy type extensions
  • fixes a bug with DATA frames
  • adds the option to install the wireshark plugin
  • adds version info to the wireshark plugin

attilakreiner
attilakreiner commented Dec 12, 2023
View reviewed changes
.../src/main/java/io/aklivity/zilla/runtime/command/dump/internal/airline/ZillaDumpCommand.java
{
if (exceptions)
{
ex.printStackTrace();
Copy link
Contributor Author

@attilakreiner attilakreiner Dec 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the -e switch for consistency with the start command. The engine is not started so it can't print exceptions, ZillaMain doesn't print them either, so I am printing them here.

@attilakreiner attilakreiner changed the title Dump 2 Add proxy extension parsing to dump command Dec 13, 2023
@attilakreiner attilakreiner changed the title Add proxy extension parsing to dump command Add jumbograms and proxy extension parsing to dump command Dec 13, 2023
@attilakreiner attilakreiner marked this pull request as ready for review December 13, 2023 18:10
@jfallows jfallows merged commit 6097caa into aklivity:develop Dec 14, 2023
@jfallows jfallows mentioned this pull request Jan 2, 2024
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfallows jfallows jfallows approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@attilakreiner @jfallows