Improve mqtt-kafka to use only one kafka consumer group per mqtt client. #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…artial data frame while computing crc32c value
jfallows
requested changes
Jan 11, 2024
| @@ -529,6 +529,8 @@ public void writeProduceEntryStart( | |||
| MutableInteger position, | |||
| long timestamp, | |||
| long ownerId, | |||
| long produceId, | |||
There was a problem hiding this comment.
Suggested change
| long produceId, | |
| long producerId, |
| entryInfo.putInt(6 * Long.BYTES + Integer.BYTES, 0x00); | ||
| entryInfo.putInt(6 * Long.BYTES + 2 * Integer.BYTES, NO_DELTA_POSITION); | ||
| entryInfo.putShort(6 * Long.BYTES + 3 * Integer.BYTES, ackMode.value()); | ||
| entryInfo.putLong(4 * Long.BYTES, produceId); |
There was a problem hiding this comment.
Suggested change
| entryInfo.putLong(4 * Long.BYTES, produceId); | |
| entryInfo.putLong(4 * Long.BYTES, producerId); |
| factories.put(KafkaBeginExFW.KIND_OFFSET_FETCH, cacheOffsetFetchFactory); | ||
| factories.put(KafkaBeginExFW.KIND_INIT_PRODUCE_ID, cacheInitProduceIdFactory); |
| @@ -96,6 +96,8 @@ public final class KafkaCacheClientProduceFactory implements BindingHandler | |||
| new Array32FW.Builder<>(new KafkaHeaderFW.Builder(), new KafkaHeaderFW()) | |||
| .wrap(new UnsafeBuffer(new byte[8]), 0, 8) | |||
| .build(); | |||
| private static final long PRODUCE_FLUSH_PRODUCE_ID = -1; | |||
There was a problem hiding this comment.
Suggested change
| private static final long PRODUCE_FLUSH_PRODUCE_ID = -1; | |
| private static final long PRODUCE_FLUSH_PRODUCER_ID = -1; |
| @@ -96,6 +96,8 @@ public final class KafkaCacheClientProduceFactory implements BindingHandler | |||
| new Array32FW.Builder<>(new KafkaHeaderFW.Builder(), new KafkaHeaderFW()) | |||
| .wrap(new UnsafeBuffer(new byte[8]), 0, 8) | |||
| .build(); | |||
| private static final long PRODUCE_FLUSH_PRODUCE_ID = -1; | |||
| private static final short PRODUCE_FLUSH_PRODUCE_EPOCH = -1; | |||
There was a problem hiding this comment.
Suggested change
| private static final short PRODUCE_FLUSH_PRODUCE_EPOCH = -1; | |
| private static final short PRODUCE_FLUSH_PRODUCER_EPOCH = -1; |
| return limit; | ||
| } | ||
|
|
||
| private final class KafkaInitProduceIdStream |
There was a problem hiding this comment.
Suggested change
| private final class KafkaInitProduceIdStream | |
| private final class KafkaInitProducerIdStream |
| } | ||
| } | ||
|
|
||
| private final class KafkaInitProduceIdClient extends KafkaSaslClient |
There was a problem hiding this comment.
Suggested change
| private final class KafkaInitProduceIdClient extends KafkaSaslClient | |
| private final class KafkaInitProducerIdClient extends KafkaSaslClient |
Comment on lines
1184
to
1188
| final InitProduceIdRequestFW initProduceIdRequest = | ||
| initProduceIdRequestRW.wrap(encodeBuffer, encodeProgress, encodeLimit) | ||
| .producerId(produceId) | ||
| .producerEpoch(produceEpoch) | ||
| .build(); |
There was a problem hiding this comment.
Suggested change
| final InitProduceIdRequestFW initProduceIdRequest = | |
| initProduceIdRequestRW.wrap(encodeBuffer, encodeProgress, encodeLimit) | |
| .producerId(produceId) | |
| .producerEpoch(produceEpoch) | |
| .build(); | |
| final InitProducerIdRequestFW initProducerIdRequest = | |
| initProducerIdRequestRW.wrap(encodeBuffer, encodeProgress, encodeLimit) | |
| .producerId(produceId) | |
| .producerEpoch(produceEpoch) | |
| .build(); |
| signaler.signalNow(originId, routedId, initialId, traceId, SIGNAL_NEXT_REQUEST, 0); | ||
| } | ||
|
|
||
| private void onDecodeInitProduceIdResponse( |
There was a problem hiding this comment.
Suggested change
| private void onDecodeInitProduceIdResponse( | |
| private void onDecodeInitProducerIdResponse( |
| @@ -185,6 +186,7 @@ scope kafka | |||
| case 253: kafka::stream::KafkaGroupBeginEx group; | |||
| case 254: kafka::stream::KafkaBootstrapBeginEx bootstrap; | |||
| case 255: kafka::stream::KafkaMergedBeginEx merged; | |||
| case 22: kafka::stream::KafkaInitProduceIdBeginEx initProduceId; | |||
There was a problem hiding this comment.
Suggested change
| case 22: kafka::stream::KafkaInitProduceIdBeginEx initProduceId; | |
| case 22: kafka::stream::KafkaInitProducerIdBeginEx initProducerId; |
jfallows
requested changes
Jan 11, 2024
|
|
||
| KafkaInitProduceIdBeginExFW initProduceIdBeginEx = beginEx.initProduceId(); | ||
| KafkaInitProducerIdBeginExFW initProduceIdBeginEx = beginEx.initProducerId(); |
There was a problem hiding this comment.
Suggested change
| KafkaInitProducerIdBeginExFW initProduceIdBeginEx = beginEx.initProducerId(); | |
| KafkaInitProducerIdBeginExFW initProducerIdBeginEx = beginEx.initProducerId(); |
jfallows
approved these changes
Jan 11, 2024
jfallows
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve mqtt-kafka to use only one kafka consumer group per mqtt client.