Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support asyncapi mqtt proxy using asyncapi.yaml #764

Merged
merged 26 commits into from
Feb 21, 2024
Merged

Support asyncapi mqtt proxy using asyncapi.yaml #764

merged 26 commits into from
Feb 21, 2024

Conversation

bmaidics
Copy link
Contributor

@bmaidics bmaidics commented Jan 25, 2024 •
edited by jfallows
Loading

Fixes #738

@bmaidics bmaidics self-assigned this Jan 25, 2024
@bmaidics bmaidics linked an issue Jan 25, 2024 that may be closed by this pull request
Support asyncapi mqtt proxy using asyncapi.yaml #738
Closed
@bmaidics bmaidics added the enhancement New feature or request label Jan 25, 2024
jfallows
jfallows requested changes Feb 8, 2024
View reviewed changes
@jfallows jfallows removed the enhancement New feature or request label Feb 9, 2024
jfallows
jfallows requested changes Feb 20, 2024
View reviewed changes
jfallows
jfallows previously approved these changes Feb 20, 2024
View reviewed changes
.../aklivity/zilla/runtime/binding/asyncapi/internal/AsyncapiClientCompositeBindingAdapter.java Outdated
this.isPlainEnabled = mqttPorts != null;
this.isTlsEnabled = mqttsPorts != null;
this.qname = binding.qname;
this.qvault = String.format("%s:%s", binding.namespace, binding.vault);
Copy link
Contributor

@jfallows jfallows Feb 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need binding.qvault as transient field on BindingConfig populated by engine to make this work properly.

Please rebase when #806 is merged to develop to pick up binding.qvault.

@jfallows jfallows merged commit 497197a into aklivity:develop Feb 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfallows jfallows jfallows approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support asyncapi mqtt proxy using asyncapi.yaml
2 participants
@bmaidics @jfallows