Fix metrics #869
Merged
Fix metrics #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attilakreiner
force-pushed
the
fix-metrics
branch
from
c4d525c to
c18ede8
Compare
jfallows
previously approved these changes
Mar 20, 2024
jfallows
previously approved these changes
Mar 25, 2024
akrambek
reviewed
Apr 3, 2024
| if (!KafkaState.replyClosed(state)) | ||
| { | ||
| state = KafkaState.closedReply(state); | ||
| //client.stream = nullIfClosed(state, client.stream); |
...java/io/aklivity/zilla/runtime/binding/kafka/internal/stream/KafkaClientDescribeFactory.java
Show resolved
Hide resolved
...java/io/aklivity/zilla/runtime/binding/kafka/internal/stream/KafkaClientDescribeFactory.java
Show resolved
Hide resolved
attilakreiner
force-pushed
the
fix-metrics
branch
from
09c5e46 to
a65740e
Compare
attilakreiner
force-pushed
the
fix-metrics
branch
from
a65740e to
8775f9d
Compare
jfallows
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change fixes an issue with the
stream.active.*metrics.