Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include expression-based phenotype columns to count_within.txt and nearest_neighbors.txt #36

Closed
ccoltharp-Akoya opened this issue May 19, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@ccoltharp-Akoya
Copy link
Collaborator

ccoltharp-Akoya commented May 19, 2020

We're missing a couple columns in 'count_within.txt' that we'd like to use for making a spatial plot using the Spatial Map Viewer. Our goal was to plot two phenotypes, but only those cells that are within 25 microns of the opposite phenotype. This would be pretty easy to do with the count_within.txt file if we had 'normal' phenotypes, but we were using two expression-based phenotypes (e.g. using Membrane PD1 (Opal 650) Mean>15.2 for PD1+). In the count_within.txt, we do see the proximity columns for how many PD1+ cells are near each cell. But, we can't tell the PD1 phenotype of each cell. The only phenotype columns listed are those where the column name starts with "Phenotype". Looks like 'nearest_neighbors.txt' is the same way.

If we input expression-based phenotypes to the Analysis app, could those phenotype columns be added to count_within.txt and nearest_neighbors.txt?

(slight tangent -- the expression we needed in order to plot the cells with a close-by PD1+ cell is ugly: ~`~\`Membrane PD1 (Opal 650) Mean\`>15.2 within 25`>0)

@AB-Kent AB-Kent added the enhancement New feature or request label May 20, 2020
@AB-Kent
Copy link
Contributor

AB-Kent commented May 20, 2020

That's a good idea. I didn't want to include all the columns from the cell seg data but including the columns needed for the phenotypes makes a lot of sense. If I copy the original column then the same expression can be used in the spatial map viewer.

@ccoltharp-Akoya
Copy link
Collaborator Author

Yep - that would work for me!

@AB-Kent
Copy link
Contributor

AB-Kent commented May 21, 2020

Regarding your tangent -- agreed, the column names for the expression-based phenotypes are awkward. A couple of options:

  • Omit the ` and ~, so your column would become Membrane PD1 (Opal 650) Mean>15.2 within 25 and the spatial maps selector would be ~`Membrane PD1 (Opal 650) Mean>15.2 within 25`>0
  • Omit the ~ and change ` to ", so your column would become "Membrane PD1 (Opal 650) Mean">15.2 within 25 and the spatial maps selector would be ~`"Membrane PD1 (Opal 650) Mean">15.2 within 25`>0

I prefer the first option, I don't think the " is needed and it adds noise. What do you think?

@ccoltharp-Akoya
Copy link
Collaborator Author

Agree - the first option is fine with me.

AB-Kent added a commit to akoyabio/phenoptr that referenced this issue May 21, 2020
AB-Kent added a commit that referenced this issue May 21, 2020
…lumns in count_within.txt and nearest_neighbors.txt

Output has nicer names for expression-based phenotypes.

Closes #36
@AB-Kent AB-Kent closed this as completed Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants