Fix solar rad summary issues

[akrherz]

No description provided.

[gemini-code-assist]

Hello @akrherz, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request addresses an issue with how solar radiation summary data is updated within IEMAccess. The primary change involves modifying the SQL query used to update the max_srad column in the summary table. Instead of simply coalescing the existing value with a new value, it now uses the greatest function to ensure that the maximum solar radiation value is correctly recorded. Additionally, a coalesce function is added to the srad_mj column update to handle potential null values. Minor changes include adding a changelog entry and adding type hints to the Observation class constructor.

Highlights

• Solar Radiation Summary Update: The max_srad update logic in the summary_update function within src/pyiem/observation.py has been corrected to use the greatest function, ensuring the maximum solar radiation value is accurately tracked.
• Null Value Handling: A coalesce function was added to the srad_mj column update in src/pyiem/observation.py to handle potential null values.
• Type Hinting: Type hints were added to the Observation class constructor in src/pyiem/observation.py for better code clarity and maintainability.

Changelog

• CHANGELOG.md
  • Improve solar radiation summary table update within IEMAccess.
• src/pyiem/observation.py
  • Modify summary_update function to use greatest function for max_srad update.
  • Add coalesce function to srad_mj column update in summary_update function.
  • Add type hints to the Observation class constructor.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

The sun's bright rays, a golden shower,
Observed and logged with careful power.
No longer lost, the peak we find,
With greatest and coalesce combined.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request addresses an issue with the solar radiation summary table update within IEMAccess. The changes involve modifications to the src/pyiem/observation.py file to improve the logic for updating max_srad and srad_mj fields. The addition of type hints to the __init__ method enhances code readability and maintainability. Overall, the changes seem reasonable and address the stated issue.

Summary of Findings

Merge Readiness

The code changes appear to address the solar radiation summary issues as described in the pull request title. The modifications to the max_srad and srad_mj fields seem appropriate, and the addition of type hints improves code clarity. Since there are no CRITICAL or HIGH severity issues, the pull request seems to be in good shape to be merged, but can still have some minor feedback. I am unable to approve the pull request, and users should have others review and approve this code before merging.

[deepsource-io]

Here's the code health analysis summary for commits aa95e0d..6c260c0. View details on DeepSource ↗.

Analysis Summary

Analyzer	Status	Summary	Link
Python	✅ Success		View Check ↗

---

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.52%. Comparing base (aa95e0d) to head (6c260c0).
Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1025   +/-   ##
=======================================
  Coverage   98.52%   98.52%           
=======================================
  Files          85       85           
  Lines       10170    10171    +1     
=======================================
+ Hits        10020    10021    +1     
  Misses        150      150           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.