📝 Write domain to weblog

[akrherz]

No description provided.

[gemini-code-assist]

Hello @akrherz, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request adds the domain to the weblog table and populates it with the value of the HTTP_HOST header. This will allow for better tracking of which domains are accessing the web application. The change involves modifying the SQL query used to insert data into the weblog table and adding the domain key to the dictionary of values passed to the query.

Highlights

• Weblog Enhancement: The pull request enhances the weblog table by adding a domain column to store the HTTP host, enabling better domain-specific analytics.
• Data Collection: The HTTP_HOST header is now captured and stored in the domain column of the weblog table, providing valuable information about the source of web requests.

Changelog

• src/pyiem/webutil.py
  • Modified the SQL query to include the domain column in the weblog table.
  • Added the domain key to the dictionary of values passed to the SQL query, populating it with the HTTP_HOST header value.
  • Line 213: Added domain to the INSERT statement.
  • Line 214: Added :domain to the VALUES statement.
  • Line 224: Added domain key to the dictionary, assigning the value from environ.get("HTTP_HOST").

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

Trivia time!

What is the purpose of the HTTP Host header?

Click here for the answer

The Host header specifies the domain name of the server to which the client is trying to connect. It is required in HTTP/1.1 requests.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a new domain column to the weblog table and populates it with the HTTP host. This is a useful addition for tracking the origin of web requests. The implementation is straightforward and seems correct.

Merge Readiness

The code changes are simple and appear correct. I don't see any immediate issues that would prevent merging. However, it would be beneficial to add a database migration to ensure the domain column exists in all environments. I am unable to directly approve this pull request, and recommend that others review and approve this code before merging.

[deepsource-io]

Here's the code health analysis summary for commits 65a72a0..cdb75e0. View details on DeepSource ↗.

Analysis Summary

Analyzer	Status	Summary	Link
Python	✅ Success		View Check ↗

---

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.52%. Comparing base (65a72a0) to head (cdb75e0).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1034   +/-   ##
=======================================
  Coverage   98.52%   98.52%           
=======================================
  Files          85       85           
  Lines       10185    10185           
=======================================
  Hits        10035    10035           
  Misses        150      150           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.