🐛 Update NCEP MRMS base URL

[akrherz]

No description provided.

[gemini-code-assist]

Hello @akrherz, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request addresses a bug by updating the base URL for NCEP MRMS (Multi-Radar Multi-Sensor) data downloads. The change modifies the get_url function in src/pyiem/mrms.py to remove the /data portion of the URL. Additionally, logging statements were added to the fetch function to provide better visibility into the file retrieval process, including when files are found in the cache or when fetching from different data centers fails. A changelog entry was also added to document the URL update.

Highlights

• Bug Fix: The primary focus is to correct the NCEP MRMS base URL used for real-time data downloads.
• URL Update: The get_url function in src/pyiem/mrms.py is modified to use the correct base URL.
• Enhanced Logging: Logging statements are added to the fetch function to track file retrieval attempts and cache hits.

Changelog

• CHANGELOG.md
  • Added a changelog entry to reflect the NCEP MRMS base URL update.
• src/pyiem/mrms.py
  • Updated the base URL for NCEP MRMS data downloads in the get_url function (line 95).
  • Added logging statements in the fetch function to track file retrieval from cache (line 118) and mtarchive (line 126).
  • Added logging statements in the fetch function to track file retrieval failures from IDP data centers (line 146).
  • Imported the LOG utility from pyiem.util (line 16).

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

Did you know?

NOAA's MRMS system integrates data from over 160 radars across the United States to create high-resolution, rapidly updating weather maps.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request updates the NCEP MRMS base URL and adds logging for debugging purposes. The changes seem straightforward and necessary for maintaining the functionality of the library. The addition of logging is also helpful for troubleshooting potential issues.

Merge Readiness

The pull request appears to be in good shape for merging. The changes are well-scoped and address a bug fix. The addition of logging enhances the maintainability of the code. I am unable to directly approve the pull request, and recommend that others review and approve this code before merging.

[deepsource-io]

Here's the code health analysis summary for commits 1d9f9df..98b9b06. View details on DeepSource ↗.

Analysis Summary

Analyzer	Status	Summary	Link
Python	✅ Success		View Check ↗

---

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.52%. Comparing base (1d9f9df) to head (98b9b06).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1035   +/-   ##
=======================================
  Coverage   98.52%   98.52%           
=======================================
  Files          85       85           
  Lines       10185    10191    +6     
=======================================
+ Hits        10035    10041    +6     
  Misses        150      150           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.