Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support passing dynamic key-value pairs in helm-template step #3795

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

michaelasper
Copy link
Contributor

implements #3753

have it working locally, will update/add tests

first time hacking on kargo internals, hopefully in the right direction

Signed-off-by: Michael Asper <masper@twilio.com>
Copy link

netlify bot commented Apr 4, 2025

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit 3c3b41e
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/67f057b9d84eae0008005dc3
😎 Deploy Preview https://deploy-preview-3795.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.25%. Comparing base (6b49a88) to head (3c3b41e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3795      +/-   ##
==========================================
+ Coverage   52.24%   52.25%   +0.01%     
==========================================
  Files         309      309              
  Lines       27601    27609       +8     
==========================================
+ Hits        14420    14428       +8     
  Misses      12400    12400              
  Partials      781      781              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Michael Asper <masper@twilio.com>
@michaelasper michaelasper marked this pull request as ready for review April 4, 2025 22:10
@michaelasper michaelasper requested review from a team as code owners April 4, 2025 22:10
@aarontams
Copy link
Contributor

aarontams commented Apr 4, 2025

Thanks @michaelasper
I reviewed the PR, and it is very promising!
Hopefully, it will be approved by the Kargo team and included in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants