Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add thematic labels to indicator #3788

Closed
martinchristov opened this issue Sep 18, 2019 · 1 comment
Closed

Add thematic labels to indicator #3788

martinchristov opened this issue Sep 18, 2019 · 1 comment
Labels
Bug
Milestone
Hot-fix 4.0.3 Mal...

Comments

@martinchristov
Copy link
Contributor

martinchristov commented Sep 18, 2019 •
edited
Loading

The granular way of working with thematic labels attached to indicators is extremely prone to error at the FE due to the complexity of handling it, waiting for IDs assigned from backend for each label, etc. This will decrease UX as the component will have to freeze to wait for backend syncs and will break the normal pattern of auto-saving.
In order to wrap this up properly we need to have a simpler way of editing the labels attached to indicator, namely as a simple list of label values:

thematic_labels: [31, 17]

This property would need to be added to the indicator and to allow GET & PATCH.
@martinchristov
Copy link
Contributor Author

Add thematic labels for qualitative indicators

punchagan added a commit that referenced this issue Sep 19, 2019
@punchagan
[#3788] Add labels field on the Indicator serializer
974d447 
The labels field contains the IDs of the `OrganisationIndicatorLabel`
objects that are related to the indicator, and not the IDs of the
`IndicatorLabel`, itself. Creation of `IndicatorLabel`s also assumes that
the IDs of the corresponding `OrganisationIndicatorLabel`s are passed in.

Closes #3788
punchagan added a commit that referenced this issue Sep 19, 2019
@punchagan
[#3788] Call distinct on the queryset after applying API filters
63a1e7d 
Complicated queries can result in responses where the list of objects being
returned is not distinct. This commit fixes that.
punchagan added a commit that referenced this issue Sep 20, 2019
@punchagan
[#3788] Call distinct on the queryset after applying API filters
e9fb526 
Complicated queries can result in responses where the list of objects being
returned is not distinct. This commit fixes that.
martinchristov added a commit that referenced this issue Sep 20, 2019
@martinchristov
[#3788] wip thematic labels UI
205ca7a
martinchristov added a commit that referenced this issue Sep 20, 2019
@martinchristov
[#3788] thematic labels done
da0eb97
punchagan added a commit that referenced this issue Sep 23, 2019
@punchagan
Revert "[#3788] Add labels field on the Indicator serializer"
ed66b15 
This reverts commit 974d447. The commit was
overwritten in the PR branch, but was merged into develop due to a bad
merge. This commit fixes a broken build on develop.
@punchagan punchagan added the Bug label Sep 23, 2019
punchagan added a commit that referenced this issue Oct 10, 2019
@punchagan
[#3788] Fix LabelListingField.to_representation to work in DRF UI
7bf8fb2 
To display the form in the Django Rest Framework UI, the serializer is
passed individual items in a queryset, instead of the whole queryset. This
commit fixes the serializer to be able to handle individual instances in the
queryset correctly.
@MichaelAkvo MichaelAkvo moved this to Done in RSR Dec 7, 2022
@MichaelAkvo MichaelAkvo added this to RSR Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
RSR
Archived in project
Milestone
Hot-fix 4.0.3 Malachite Kingfisher
Development

No branches or pull requests
2 participants
@punchagan @martinchristov