Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breadcrumbs on mobile on rtl pages #4699

Merged
merged 1 commit into from
Mar 14, 2025
Merged

Fix breadcrumbs on mobile on rtl pages #4699

merged 1 commit into from
Mar 14, 2025

Conversation

AshGDS
Copy link
Contributor

@AshGDS AshGDS commented Mar 14, 2025

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

What / Why

  • Make our .direction-rtl class more specific by only working in conjunction with .govuk-main-wrapper
  • Fixes a bug with the breadcrumbs on mobile

Trello: https://trello.com/c/Xl68FLDw/529-fix-breadcrumbs-on-mobile-on-rtl-pages

Screenshots

Before After
Screenshot 2025-03-14 at 10-19-37 تصريح وزير شؤون الشرق الأوسط في البرلمان بشأن سورية - GOV UK after

@AshGDS AshGDS self-assigned this Mar 14, 2025
@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-4699 March 14, 2025 10:22 Inactive
Copy link
Contributor

@sairamya93 sairamya93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AshGDS AshGDS merged commit 1fe9d3e into main Mar 14, 2025
14 checks passed
@AshGDS AshGDS deleted the direction-rtl-fix branch March 14, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants