Render non filterable text facets in a list #4700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leenagupte
force-pushed
the
render-non-filterable-text-facets
branch
from
b66a4a5 to
3ab472d
Compare
There's a case where a facet could have an array of allowed values but
not be filterable, so a link to a finder shouldn't be rendered.
This was not being picked up so rather than rendering:
```
Reason for protection: Application to UK scheme from 2021
```
A hash was rendered instead:
```
Reason for protection:
{:label=>"Application to UK scheme from 2021", :value=>"uk-gi-after-2021"}
```
A new type is added to account for this case "preset_text". This is
"text" that the publisher selected from a redefined set of options, but
is not filterable so shouldn't be a link.
This takes the label value with the new "preset_text" type and renders it as a comma separated list. The change from using an if/else to a case statement was enforced by rubocop after the addition of a second "elsif".
leenagupte
force-pushed
the
render-non-filterable-text-facets
branch
from
3ab472d to
605ea6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
There's a case where a facet could have an array of allowed values but
not be filterable, so a link to a finder shouldn't be rendered.
This was not being picked up so rather than rendering:
A hash was rendered instead:
Why
This case was missed when the specialist documents were moved over.
How
A new type is added to account for this case "preset_text". This is
"text" that the publisher selected from a redefined set of options, but
is not filterable so shouldn't be a link.
Screenshots?
On GOV.UK (government-frontend)
Before (frontend)
After