Bump rubocop-govuk from 5.0.8 to 5.0.9 #3636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
|
This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs. Follow these steps if you are doing a Rails upgrade. |
yndajas
approved these changes
Mar 10, 2025
| def url_encode(str) | ||
| ERB::Util.url_encode(str) | ||
| end | ||
| delegate :url_encode, to: :'ERB::Util' |
There was a problem hiding this comment.
question: is it worth making the same include change here? Guessing it's working because of some difference between RSpec and minitest
There was a problem hiding this comment.
Good idea. I didn't spot this one as the tests were passing.
Bumps [rubocop-govuk](https://github.com/alphagov/rubocop-govuk) from 5.0.8 to 5.0.9. - [Changelog](https://github.com/alphagov/rubocop-govuk/blob/main/CHANGELOG.md) - [Commits](alphagov/rubocop-govuk@v5.0.8...v5.0.9) --- updated-dependencies: - dependency-name: rubocop-govuk dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
It is unclear why we are delegating this method to `ERB::Util` instead of simply including the module.
brucebolt
force-pushed
the
dependabot/bundler/rubocop-govuk-5.0.9
branch
from
62d81dd to
88cb15a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps rubocop-govuk from 5.0.8 to 5.0.9.
Changelog
Sourced from rubocop-govuk's changelog.
Commits
927e7dbMerge pull request #461 from alphagov/add-actionlint-to-all-repos7cd8dceMerge pull request #467 from alphagov/dependabot/bundler/rubocop-eq-1.73.2af82b05Update rubocop requirement from = 1.73.1 to = 1.73.27735806Merge pull request #466 from alphagov/dependabot/bundler/rubocop-rails-eq-2.30.316e9a47Update rubocop-rails requirement from = 2.30.2 to = 2.30.38a1d4c2Ratchet version to pass version checks06f5005Merge pull request #465 from alphagov/dependabot/bundler/rubocop-eq-1.73.1fe88b75Update rubocop requirement from = 1.73.0 to = 1.73.14301a8aMerge pull request #464 from alphagov/dependabot/bundler/rubocop-ast-eq-1.38.1fab9c36Update rubocop-ast requirement from = 1.38.0 to = 1.38.1Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)