Add missing phrase for maternity-paternity-calculator #1835
Conversation
|
NOTE. Liz is going to check this wording with the department. If/when we get the OK, I'll update the regression test file checksums and artefacts. |
chrisroos
force-pushed
the
add-missing-phrase-for-maternity-paternity-calculator
branch
from
659aae3 to
9b35463
Compare
|
I've rebased this branch on master and updated it now that maternity-paternity-calculator uses ERB templates. I've force pushed this branch. |
|
LGTM but it looks like you'll need to rebase again |
chrisroos
force-pushed
the
add-missing-phrase-for-maternity-paternity-calculator
branch
from
9b35463 to
2389d28
Compare
|
I've rebased on top of master and force pushed now that the ERB templates are indented. |
|
|
|
@tadast: Did you hear from Liz that this is OK to deploy? |
|
@tadast: Bump! Did you hear from Liz that the wording has been approved? |
|
Initially I thought it's good to go but I must've confused it with something else. Liz hasn't heard back yet for this change unfortunately. |
chrisroos
force-pushed
the
add-missing-phrase-for-maternity-paternity-calculator
branch
from
2389d28 to
7528ba8
Compare
|
I've just rebased and force pushed this branch. @lutgendorff: Have you heard anything back from the department about this change? |
chrisroos
force-pushed
the
add-missing-phrase-for-maternity-paternity-calculator
branch
from
7528ba8 to
2a831d1
Compare
|
I've just rebased and force pushed this branch again. |
chrisroos
force-pushed
the
add-missing-phrase-for-maternity-paternity-calculator
branch
from
2a831d1 to
6f3debf
Compare
|
I've rebased and force-pushed this branch. One thing to note is that the message for paternity adoption has recently been changed to mention "15 days" while our new adoption message mentions "28 days". I wonder whether these should be the same. |
|
Liz has said that we should update the text to use "15 days" instead of "28 days" and then to get this deployed. I'm going to make the change and get this merged. |
The text was supplied by @lutgendorff. This adds a useful phrase when `leave_type == 'adoption'`. Before converting to ERB, a `leave_type` of 'adoption' resulted in the "adoption_spp_claim_link" placeholder appearing in the outcome page. See the following URL for an example of the placeholder appearing incorrectly (NOTE. This will no longer be visible once the switch to ERB has been deployed): https://www.gov.uk/maternity-paternity-calculator/y/adoption/no/2015-04-05/2015-04-06/yes/no/yes/2015-04-06/2015-01-01/2014-11-01/every_4_weeks/3000.0/usual_paydates/2015-01-01
Updated using:
$ rails r script/generate-checksums-for-smart-answer.rb \
maternity-paternity-calculator
Updated using:
$ time RUN_REGRESSION_TESTS=maternity-paternity-calculator \
ruby test/regression/smart_answers_regression_test.rb
chrisroos
force-pushed
the
add-missing-phrase-for-maternity-paternity-calculator
branch
from
6f3debf to
931b851
Compare
…ty-paternity-calculator Add missing phrase for maternity-paternity-calculator
chrisroos
deleted the
add-missing-phrase-for-maternity-paternity-calculator
branch
The text was supplied by @lutgendorff.
This replaces the "adoption_spp_claim_link" placeholder with a useful phrase.
Expected changes
Before
After