Update checksum data for redundancy smart answers #2004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 👍 |
I noticed that the checksum data didn't include the redundancy_pay.rb shared
logic.
Updated using:
$ rails r script/generate-checksums-for-smart-answer.rb \
calculate-employee-redundancy-pay \
lib/smart_answer_flows/shared_logic/redundancy_pay.rb
I noticed that the checksum data didn't include the redundancy_pay.rb shared
logic.
Updated using:
$ rails r script/generate-checksums-for-smart-answer.rb \
calculate-your-redundancy-pay \
lib/smart_answer_flows/shared_logic/redundancy_pay.rb
chrisroos
force-pushed
the
update-checksum-data-for-redundancy-smart-answers
branch
from
e22aede to
f4d40c7
Compare
|
I've rebased on master and force pushed ready to merge. |
chrisroos
added a commit
that referenced
this pull request
Oct 14, 2015
…dancy-smart-answers Update checksum data for redundancy smart answers
chrisroos
deleted the
update-checksum-data-for-redundancy-smart-answers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a change to redundancy_pay.rb in another branch and was surprised not to have to update the checksum data. I realised that it was because the checksum data didn't include the redundancy_pay shared logic.
This branch rectifies that.
Expected user-visible changes