Update regression test input YAML to current YAML version #2011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Loading and saving all the files has removed some of the comments that were added to describe why certain values were chosen:
Do you think we should try to retain those? |
|
Oops! Yes. I'll sort that now. Well spotted! |
floehopper
force-pushed
the
update-regression-test-input-yaml-to-current-yaml-version
branch
from
55bab67 to
72bc610
Compare
|
I've updated the middle "Update YAML files using current YAML version" commit to include manually re-adding the comments and updated the commit message to explain how I did it. I've then force-pushed. |
|
Looks good to me, although presumably you'll need to regenerate all the checksum data too? |
|
Yes, I'll update checksums now and get the PR merged. Thanks. |
floehopper
force-pushed
the
update-regression-test-input-yaml-to-current-yaml-version
branch
from
72bc610 to
0d1d0ca
Compare
|
I've just added a commit which updates the checksums and force-pushed in preparation for merging. |
The version of YAML has changed since these files were generated and the newer
version seems to generate slightly different YAML output e.g. it uses single-
quotes instead of double-quotes.
Because of this, when we make a change and regenerate these files, it's
difficult to see the woods for the trees. By loading and saving all the YAML
files in this commit, I hope that it will be easier to see what's changed in
later commits.
Some of the `*-questions-and-responses.yml` files included comments which
would've been lost in this automated process. So I ran the following command
to identify them:
grep -R "#" test/data/*
I then ran the following command to do the automatic update:
rails r script/update-yaml.rb
And finally I manually edited the files to re-add the comments identified
above. I re-ran the `grep` command to check I hadn't missed any comments.
This reverts commit edcd63e. Now that I've used this script it is surplus to requirements.
floehopper
force-pushed
the
update-regression-test-input-yaml-to-current-yaml-version
branch
from
0d1d0ca to
c7f1d7c
Compare
|
I've just rebased this against master and force-pushed in preparation for merging. |
floehopper
added a commit
that referenced
this pull request
Oct 15, 2015
…aml-to-current-yaml-version Update regression test input YAML to current YAML version
floehopper
deleted the
update-regression-test-input-yaml-to-current-yaml-version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version of YAML has changed since these files were generated and the
newer version seems to generate slightly different YAML output e.g. it uses
single-quotes instead of double-quotes.
Because of this, when we make a change and regenerate these files, it's
difficult to see the woods for the trees. By loading and saving all the YAML
files in this PR, I hope that it will be easier to see what's changed in
later commits.