Add missing question option translations for PartYearProfitTaxCreditsFlow #2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flow was relying on the fallback to the option key which was removed in #2005. The following exception has just occurred in production [1]: I18n::MissingTranslationData: translation missing: en-GB.flow.part-year-profit-tax-credits.have_you_stopped_trading?.options.yes This commit adds unit tests which would've picked up the problem and adds the missing translations. [1]: https://errbit.publishing.service.gov.uk/apps/533c35ae0da1159384044f5f/problems/56233f4b6578634c6c971600
floehopper
force-pushed
the
add-missing-question-option-translations-for-part-year-profit-tax-credits
branch
from
c936866 to
138808e
Compare
|
LGTM 👍 |
floehopper
added a commit
that referenced
this pull request
Oct 19, 2015
…anslations-for-part-year-profit-tax-credits Add missing question option translations for PartYearProfitTaxCreditsFlow
floehopper
deleted the
add-missing-question-option-translations-for-part-year-profit-tax-credits
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected user-visible changes
Visit this example URL.
Before the change this resulted in a 503 error page with the following message: "Sorry, we are experiencing technical difficulties".
After the change it should display the "Have you stopped trading?" question page correctly:
## Technical detailsThis flow was relying on the fallback to the option key which was removed
in #2005. The following exception has just occurred in production 1:
This commit adds unit tests which would've picked up the problem and adds
the missing translations.