Avoid displaying question page titles for Smartdown flows #2029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 👍 |
This removes the `h2.page-title` element from appearing on a question page. Specifically, it means that the conditional (`<% if @presenter.page_title %>`) on line 20 of the _content.html.erb partial is never true. This mirrors the behaviour in Ruby Smart Answers and will (hopefully) make it easier to convert pay-leave-for-parents from Smartdown to Ruby. This is because it'll be easier to see any differences in the regression test output if we're expecting them to be identical. I considered implementing SmartAnswerPresenter#page_title instead but don't think the concept of a page title is so useful now that we only have single questions per page. I've regenerated the test artefacts for pay-leave-for-parents (the only remaining Smartdown flow) as part of this commit as there weren't many changes.
The effect of this change is to remove the question page title from the "Previous answers" section that appears at the bottom of each question page. Specifically, it means that the first conditional (`<%- if question_page.title -%>`) in the _collapsed_question.html.erb partial is never true. This mirrors the behaviour in Ruby Smart Answers and will (hopefully) make it easier to convert pay-leave-for-parents from Smartdown to Ruby. This is because it'll be easier to see any differences in the regression test output if we're expecting them to be identical. I considered implementing this same functionality in Ruby Smart Answers instead but don't think the concept of a page title is so useful now that we only have single questions per page. I've regenerated the test artefacts for pay-leave-for-parents (the only remaining Smartdown flow) as part of this commit as there weren't many changes.
chrisroos
force-pushed
the
avoid-displaying-question-page-titles-for-smartdown-flows
branch
from
d308973 to
5c5d4fc
Compare
|
I've rebased and force pushed in preparation for merging. |
chrisroos
added a commit
that referenced
this pull request
Oct 22, 2015
…-titles-for-smartdown-flows Avoid displaying question page titles for Smartdown flows
chrisroos
deleted the
avoid-displaying-question-page-titles-for-smartdown-flows
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm hoping this'll make it easier to convert pay-leave-for-parents from Smartdown to a Ruby Smart Answer.
By not displaying question page titles for Smartdown flows (pay-leave-for-parents is the only Smartdown flow left) I hope we have a set of regression test artefacts that remain constant after the conversion to Ruby.
I think it's OK to remove these question page titles as I don't think they've been adding much value since we converted the last remaining Smartdown flow with multiple questions per page to use single questions per page.
Expected changes
Before
After