Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to Hong Kong passport in Cantonese #2030

Merged
merged 2 commits into from
Dec 2, 2015

Conversation

erkde
Copy link
Contributor

@erkde erkde commented Oct 21, 2015

PT Story: https://www.pivotaltracker.com/story/show/102753766

Adds a link to a document for an overseas passport outcome, explaining how to apply for a passport renewal and replacement for Hong Kong residents in Cantonese.

Expected changes

screen shot 2015-12-02 at 18 40 38

@erkde erkde force-pushed the add-link-to-hong-kong-passport-in-cantonese branch 2 times, most recently from 6c60168 to de84d88 Compare October 21, 2015 13:12
@erkde erkde changed the title Add link to hong kong passport in cantonese Add link to Hong Kong passport in Cantonese Oct 21, 2015
@floehopper
Copy link
Contributor

Looks good to me 👍

@floehopper floehopper self-assigned this Oct 21, 2015
@erkde erkde force-pushed the add-link-to-hong-kong-passport-in-cantonese branch 2 times, most recently from a20b568 to b870dee Compare October 22, 2015 10:04
@chrisroos
Copy link
Contributor

I've added a comment to the PT story asking Abi whether we've heard back from the department about this change.

@chrisroos
Copy link
Contributor

Abi has replied to say that this is currently blocked by some content changes that the department need to make.

@chrisroos chrisroos force-pushed the add-link-to-hong-kong-passport-in-cantonese branch from b870dee to 0ecd4d8 Compare November 18, 2015 11:24
@chrisroos
Copy link
Contributor

I've rebased this branch on master and force-pushed to try to avoid it getting too out of date.

@chrisroos chrisroos force-pushed the add-link-to-hong-kong-passport-in-cantonese branch from 0ecd4d8 to 8c03458 Compare November 23, 2015 11:05
@chrisroos
Copy link
Contributor

I've rebased on master and force pushed to avoid this branch getting too out of date.

@erkde
Copy link
Contributor Author

erkde commented Nov 26, 2015

Just checked, waiting on a wording change for this so will probably need to be updated.

@erkde erkde force-pushed the add-link-to-hong-kong-passport-in-cantonese branch from 8c03458 to a60f1d8 Compare December 2, 2015 12:14
@erkde
Copy link
Contributor Author

erkde commented Dec 2, 2015

Rebased on master again, updating with wording change.

@erkde
Copy link
Contributor Author

erkde commented Dec 2, 2015

This has been updated, so needs a quick check before being able to merge

@erkde erkde removed the LGTM label Dec 2, 2015
@chrisroos
Copy link
Contributor

Looks good to me.

@chrisroos chrisroos added the LGTM label Dec 2, 2015
@erkde erkde force-pushed the add-link-to-hong-kong-passport-in-cantonese branch from 07ac1fb to 3bb2190 Compare December 2, 2015 18:39
erkde added a commit that referenced this pull request Dec 2, 2015
…-in-cantonese

Add link to Hong Kong passport in Cantonese
@erkde erkde merged commit 812be38 into master Dec 2, 2015
@erkde erkde deleted the add-link-to-hong-kong-passport-in-cantonese branch December 2, 2015 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants