Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flow auditor code #2034

Merged
merged 3 commits into from
Oct 26, 2015
Merged

Remove flow auditor code #2034

merged 3 commits into from
Oct 26, 2015

Conversation

chrisroos
Copy link
Contributor

The flow_audit script would analyse a Smart Answer and inspect the blocks passed to next_node in an attempt to list possible next nodes for each question. The output could be used to define permitted_next_nodes for each question.

PR #2010 added the equivalent of permitted_next_nodes to each question and also ensured that we have to specify permitted next nodes in future. As such, I'm less convinced that this flow_audit script is useful.

Expected changes

  • None

This script attempted to work out possible next nodes for Smart Answers that
used `next_node` with a block. You're now required to specify the set of
permitted next nodes when calling `next_node` with a block so I'm not convinced
this script is particularly useful.
This was only being used by the FlowAudit script which was removed in the commit
titled "Remove FlowAudit script".
This was only be used by the FlowAuditor class, which was removed in the commit
titled "Remove FlowAuditor class".
@floehopper
Copy link
Contributor

LGTM 👍

@floehopper floehopper self-assigned this Oct 26, 2015
chrisroos added a commit that referenced this pull request Oct 26, 2015
@chrisroos chrisroos merged commit 58837ae into master Oct 26, 2015
@chrisroos chrisroos deleted the remove-flow-auditor-code branch October 26, 2015 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants