Remove flow auditor code #2034
Merged
Remove flow auditor code #2034
+0
−149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This script attempted to work out possible next nodes for Smart Answers that used `next_node` with a block. You're now required to specify the set of permitted next nodes when calling `next_node` with a block so I'm not convinced this script is particularly useful.
This was only being used by the FlowAudit script which was removed in the commit titled "Remove FlowAudit script".
This was only be used by the FlowAuditor class, which was removed in the commit titled "Remove FlowAuditor class".
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
flow_auditscript would analyse a Smart Answer and inspect the blocks passed tonext_nodein an attempt to list possible next nodes for each question. The output could be used to definepermitted_next_nodesfor each question.PR #2010 added the equivalent of
permitted_next_nodesto each question and also ensured that we have to specify permitted next nodes in future. As such, I'm less convinced that thisflow_auditscript is useful.Expected changes