Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add qualifying week to maternity, paternity and adoption #2040

Merged
merged 2 commits into from
Oct 29, 2015

Conversation

erkde
Copy link
Contributor

@erkde erkde commented Oct 28, 2015

Rationale

This change updates the maternity, paternity and adoption smart answer calculators by asking the user if they were, or will be, employed during the qualifying week - rather than the present date when they are completing the questions.

The qualifying week (QW) is, broadly, the 15th week before the expected week of childbirth or adoption. It's worked out by finding the Sunday before the due or match date (or due day itself if it's a Sunday). The QW is 15 Sundays back from there.

For example, if the due date is 1 January 2016, the QW is 13 September.

For further details see:
https://www.pivotaltracker.com/n/projects/1270592/stories/104083442

Expected changes

  • Example Maternity URL
    • Question should be: "Was the employee (or will they be) on your payroll on 13 September 2015?"

screen shot 2015-10-28 at 4 43 54 pm

- [Example Paternity URL](https://www.gov.uk/maternity-paternity-calculator/y/paternity/yes/2016-01-01/2016-01-01/yes/yes/yes) - Question should be: "Was the employee (or will they be) on your payroll on 13 September 2015?"

screen shot 2015-10-28 at 4 47 43 pm

- [Example Adoption URL](https://www.gov.uk/maternity-paternity-calculator/y/adoption/yes/2016-01-01/2016-01-01/yes/yes/yes) - Question should be: "Was the employee (or will they be) on your payroll on 13 September 2015?"

screen shot 2015-10-28 at 4 48 56 pm

@tadast
Copy link
Contributor

tadast commented Oct 29, 2015

The changes look good to me, however it would be better to have all the rationale behind the change directly in commit notes and the PR description. People looking at git/GH history in future may not have access to pivotal or we may not use pivotal anymore. Also, we're developing in the public by default, so we should make all information available to the public :)

Having said that, you can still reference pivotal for internal purposes.

@erkde
Copy link
Contributor Author

erkde commented Oct 29, 2015

Thanks @tadast - good points, I've update the description with a rationale section outlining the reason for the change.

@tadast
Copy link
Contributor

tadast commented Oct 29, 2015

LGTM after amending the commit note 👍

erkde added 2 commits October 29, 2015 14:25
This change updates the maternity, paternity and adoption smart answer calculators by asking the user if they were, or will be, employed during the qualifying week - rather than the present date when they are completing the questions.

The qualifying week (QW) is, broadly, the 15th week before the expected week of childbirth or adoption. It's worked out by finding the Sunday before the due or match date (or due day itself if it's a Sunday). The QW is 15 Sundays back from there.

For example, if the due date is 1 January 2016, the QW is 13 September.
@erkde erkde force-pushed the add-qualifying-week-to-maternity-and-adoption branch from 40644cf to 8f5593c Compare October 29, 2015 14:27
erkde added a commit that referenced this pull request Oct 29, 2015
…ty-and-adoption

Add qualifying week to maternity, paternity and adoption
@erkde erkde merged commit c6e6eb3 into master Oct 29, 2015
@erkde erkde deleted the add-qualifying-week-to-maternity-and-adoption branch October 29, 2015 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants