Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Publishing API v2 #2057

Merged
merged 1 commit into from
Nov 6, 2015
Merged

Use Publishing API v2 #2057

merged 1 commit into from
Nov 6, 2015

Conversation

tijmenb
Copy link
Contributor

@tijmenb tijmenb commented Nov 5, 2015

The new V2 endpoint:

  • works by content_id, which means we can more easily change slugs in the future
  • allows us to only send the content, not the links. The links will contain the taggings for this content item, and tagging them separately will enable us to tag from more than one tool. Without this "content-only", this app would overwrite taggings done by other apps.

cc @rboulton

Expected observable changes

  • None

@danielroseman
Copy link
Contributor

v2 put_content sends the item as draft only. You need to also call publish(content_id, update_type) to actually mark the content as live and sent it to the live content-store,.

tijmenb added a commit to alphagov/publishing-api that referenced this pull request Nov 5, 2015
When migrating smart-answers to V2
(alphagov/smart-answers#2057,), I got the error
that my base_path wasn't valid, which threw me off.

Having a presence validation will also tell the user when a `base_path`
is missing from the payload.

This will ease migration, as base_path was previously not required.
@tijmenb
Copy link
Contributor Author

tijmenb commented Nov 5, 2015

@danielroseman updated PR.

The new V2 endpoint:

- works by content_id, which means we can more easily change slugs in
the future
- allows us to only send the content, not the links. The links will
contain the taggings for this content item, and tagging them separately
will enable us to tag from more than one tool. Without this
"content-only", this app would overwrite taggings done by other apps.
rboulton added a commit that referenced this pull request Nov 6, 2015
@rboulton rboulton merged commit 2e16561 into master Nov 6, 2015
@rboulton rboulton deleted the use-pub-api-v2 branch November 6, 2015 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants